LycheeOrg / Lychee-front

JS implementation of Lychee frontend
https://lycheeorg.github.io/
MIT License
48 stars 53 forks source link

'About' window stays open when viewing 'Settings' and other sections in sidebar #304

Closed vjuliano closed 2 years ago

vjuliano commented 2 years ago

Detailed description of the problem [REQUIRED]

If an 'About' window is opened when viewing an album or photo, and not closed before navigating away, when viewing the 'Settings' page the 'About' window opens again. This also happens with other pages accessed via the Settings side bar. There is no way to close it from these pages. This happens on both desktop and mobile.

Steps to reproduce the issue

Steps to reproduce the behavior:

  1. Go to any album or photo
  2. Click the 'i' icon in top bar to open 'About'
  3. Click '<' in top bar to navigate back to main gallery.
  4. Click settings on top left and open 'Settings;
  5. 'About' is open and there is no way to close it.

Screenshots If applicable, add screenshots to help explain your problem. Screen Shot 2022-06-28 at 5 31 07 AM

Output of the diagnostics [REQUIRED]

Diagnostics
-----------
Warning: Dropbox import not working. dropbox_key is empty.

System Information
------------------
Lychee Version (git):            master (8d1cf2f) --  - 2 commits behind master 01541c3 (1 days ago)
DB Version:                      4.5.1

composer install:                dev
APP_ENV:                         production
APP_DEBUG:                       false

System:                          Linux
PHP Version:                     8.1
PHP User agent:                  Lychee/4 (https://lycheeorg.github.io/)
Timezone:                        America/Los_Angeles
Max uploaded file size:          500M
Max post size:                   500M
Max execution time:              200
MySQL Version:                   10.8.3-MariaDB-1:10.8.3+maria~jammy

Imagick:                         1
Imagick Active:                  1
Imagick Version:                 1691
GD Version:                      2.3.0

Config Information
------------------
version:                         040501
check_for_updates:               1
sorting_photos_col:              created_at
sorting_photos_order:            DESC
sorting_albums_col:              max_taken_at
sorting_albums_order:            DESC
imagick:                         1
skip_duplicates:                 1
small_max_width:                 0
small_max_height:                360
medium_max_width:                1920
medium_max_height:               1080
lang:                            en
layout:                          1
image_overlay_type:              none
default_license:                 CC-BY-NC-ND-4.0
compression_quality:             90
full_photo:                      1
delete_imported:                 1
Mod_Frame:                       1
Mod_Frame_refresh:               30
thumb_2x:                        1
small_2x:                        1
medium_2x:                       1
landing_page_enable:             1
landing_owner:                   Vincent Juliano
landing_title:                   Life on 35mm
landing_subtitle:                Click top right to continue.  Next page top left to login
landing_facebook:                
landing_flickr:                  
landing_twitter:                 
landing_instagram:               
landing_youtube:                 
landing_background:              /uploads/medium/3d4bf4e35e5ea06853d7983c88efb6a2.jpg
site_title:                      Vince Juliano's Photo Gallery
site_copyright_enable:           1
site_copyright_begin:            2021
site_copyright_end:              2022
additional_footer_text:          "Alex's Photos" copyright Alex Panicacci 2022
display_social_in_gallery:       0
public_search:                   0
SL_enable:                       0
SL_for_admin:                    0
public_recent:                   0
recent_age:                      60
public_starred:                  0
downloadable:                    1
photos_wraparound:               1
map_display:                     1
zip64:                           1
map_display_public:              1
map_provider:                    Wikimedia
force_32bit_ids:                 0
map_include_subalbums:           1
update_check_every_days:         3
has_exiftool:                    1
share_button_visible:            1
import_via_symlink:              0
has_ffmpeg:                      1
location_decoding:               1
location_decoding_timeout:       30
location_show:                   1
location_show_public:            1
rss_enable:                      0
rss_recent_days:                 7
rss_max_items:                   100
prefer_available_xmp_metadata:   0
editor_enabled:                  1
lossless_optimization:           1
swipe_tolerance_x:               150
swipe_tolerance_y:               250
local_takestamp_video_formats:   .avi|.mov
log_max_num_line:                10000
unlock_password_photos_with_url_param: 0
nsfw_visible:                    0
nsfw_blur:                       0
nsfw_warning:                    0
nsfw_warning_admin:              0
map_display_direction:           1
album_subtitle_type:             oldstyle
upload_processing_limit:         4
public_photos_hidden:            1
new_photos_notification:         1
legacy_id_redirection:           1

Browser and system

Firefox 101.0.1 Mac Os 12.4

kamil4 commented 2 years ago

As luck would have it, I committed a fix for this just two days ago. Update to the latest master and you should be all set...

Also, I seem to remember that at least on the desktop you can close it with the i keyboard shortcut.