LycheeOrg / Lychee-front

JS implementation of Lychee frontend
https://lycheeorg.github.io/
MIT License
48 stars 53 forks source link

Make album.getID more robust #317

Closed kamil4 closed 2 years ago

kamil4 commented 2 years ago

Fixes https://github.com/LycheeOrg/Lychee/issues/1483

I'm honestly not sure what purpose those selectors serve at this point. There was a comment Search above them but that's definitely outdated now that the search results are in album.json. I didn't want to introduce some other embarrassing last-minute bugs by removing them so I just made them more robust instead...

nagmat84 commented 2 years ago

Added some fixes in https://github.com/LycheeOrg/Lychee-front/pull/317/commits/a46de8a39958fcaf28b31af8c1a03152142f6bf8:

nagmat84 commented 2 years ago

I'm honestly not sure what purpose those selectors serve at this point.

Yes, I definitely understand that feeling. I have the same problem and my IDE is also complaining about these selectors constantly. Irrespective, of any work on a Livewire frontend I have been considering to gradually transform the JS frontend via several PRs into something which is more maintainable, more modern and more efficient than we have now. This would also involve to remove most of the CSS selectors. I am just lacking the time.

But this leads me to https://github.com/LycheeOrg/basicModal/pull/3 and https://github.com/LycheeOrg/basicModal/pull/4 which are still open. This would also be one (tiny, tiny) step into that direction.