search

LycheeOrg / Lychee

A great looking and easy-to-use photo-management-system you can run on your server, to manage and share photos.
https://lycheeorg.github.io/
MIT License
3.42k stars 303 forks source link

[Enhancement] Additional 'landing_background' config options #1106

Open MikeTheTux opened 3 years ago

MikeTheTux commented 3 years ago

landing_background should provide the following additional config options:

scottlimmer commented 3 years ago

I can have a look at this one. Anything in the refactoring I should take into consideration? @ildyria @nagmat84

nagmat84 commented 3 years ago

I guess you want to start your development branch on top of master? The main differences between the re-factored architecture of the albums and the current master branch is the way how albums and pictures are queried.

You basically have two options:

a) Start on top of the branch with the re-factored architecture. That would help me because then I won't need to merge your changes into the branch with the re-factored architecture later. However you should be prepared that your PR might take some while until it gets integrated into master depending on how long it takes to merge the re-factored architecture.

b) Start an top of the master branch and document the parts which query the DB very well to ease later re-factoring.

If I was you I would take option b), if I was me (oh, wait I am me), then I would take option a), so that my future-me has less to do.

Despite from that there is nothing in particular.

scottlimmer commented 3 years ago

I'll start with the master branch as base and we can get the functionality right. Can look at merging to the refactored arch after that.