LycheeOrg / Lychee

A great looking and easy-to-use photo-management-system you can run on your server, to manage and share photos.
https://lycheeorg.github.io/
MIT License
3.4k stars 301 forks source link

New Photos Email Has Broken Thumbnails #1686

Closed vjuliano closed 1 year ago

vjuliano commented 1 year ago

Detailed description of the problem [REQUIRED]

The new photos weekly email has all broken thumbnails. It looks like they link back to password protected files. As none of my photos are in public albums, it makes this email sort of pointless. Could we generate public thumbnails for the email or somehow handle this better?

Steps to reproduce the issue

Steps to reproduce the behavior:

  1. Add private photos
  2. Open weekly notification email
  3. See none of the thumbnails load

Screenshots Screen Shot 2023-01-03 at 12 23 31 PM

Output of the diagnostics [REQUIRED]

Diagnostics
-------
Warning: Dropbox import not working. dropbox_key is empty.
Info: Latest version of PHP is 8.2

System Information
--------------
Lychee Version (git):                    local (2902bee) -- Could not compare.
DB Version:                              4.6.5

composer install:                        dev
APP_ENV:                                 production
APP_DEBUG:                               false

System:                                  Linux
PHP Version:                             8.1.13
PHP User agent:                          Lychee/4 (https://lycheeorg.github.io/)
Timezone:                                America/Los_Angeles
Max uploaded file size:                  200M
Max post size:                           200M
Max execution time:                      200
MySQL Version:                           10.9.4-MariaDB-1:10.9.4+maria~ubu2204

exec() Available:                        yes
Imagick Available:                       1
Imagick Enabled:                         1
Imagick Version:                         1691
GD Version:                              2.3.3
Number of foreign key:                   26 found.

Config Information
--------------
version:                                 040605
check_for_updates:                       1
sorting_photos_col:                      created_at
sorting_photos_order:                    DESC
sorting_albums_col:                      max_taken_at
sorting_albums_order:                    DESC
imagick:                                 1
skip_duplicates:                         1
small_max_width:                         0
small_max_height:                        360
medium_max_width:                        1920
medium_max_height:                       1080
lang:                                    en
layout:                                  1
image_overlay_type:                      none
default_license:                         CC-BY-NC-ND-4.0
compression_quality:                     90
grants_full_photo_access:                1
delete_imported:                         1
mod_frame_enabled:                       1
mod_frame_refresh:                       30
thumb_2x:                                1
small_2x:                                1
medium_2x:                               1
landing_page_enable:                     1
site_owner:                              Vincent Juliano
landing_title:                           Life on 35mm
landing_subtitle:                        Click top right to continue.  Next page top left to login
sm_facebook_url:                         
sm_flickr_url:                           
sm_twitter_url:                          
sm_instagram_url:                        
sm_youtube_url:                          
landing_background:                      dist/cat.webp
site_title:                              Vince Juliano's Photo Gallery
footer_show_copyright:                   1
site_copyright_begin:                    2021
site_copyright_end:                      2023
footer_additional_text:                  "Alex's Photos" copyright Alex Panicacci 2022
footer_show_social_media:                0
public_search:                           0
SL_enable:                               0
SL_for_admin:                            0
public_recent:                           0
recent_age:                              60
public_starred:                          0
grants_download:                         1
photos_wraparound:                       1
map_display:                             1
zip64:                                   1
map_display_public:                      1
map_provider:                            Wikimedia
force_32bit_ids:                         0
map_include_subalbums:                   1
update_check_every_days:                 3
has_exiftool:                            1
share_button_visible:                    1
import_via_symlink:                      0
has_ffmpeg:                              1
location_decoding:                       1
location_decoding_timeout:               30
location_show:                           1
location_show_public:                    1
rss_enable:                              0
rss_recent_days:                         7
rss_max_items:                           100
prefer_available_xmp_metadata:           0
editor_enabled:                          1
lossless_optimization:                   1
swipe_tolerance_x:                       150
swipe_tolerance_y:                       250
local_takestamp_video_formats:           .avi|.mov
log_max_num_line:                        10000
unlock_password_photos_with_url_param:   0
nsfw_visible:                            0
nsfw_blur:                               0
nsfw_warning:                            0
nsfw_warning_admin:                      0
nsfw_banner_override:                    
map_display_direction:                   1
album_subtitle_type:                     oldstyle
upload_processing_limit:                 4
public_photos_hidden:                    1
new_photos_notification:                 1
legacy_id_redirection:                   1
zip_deflate_level:                       6
SA_enabled:                              1
default_album_protection:                1
allow_username_change:                   1

About

Browser and system

Server: Ubuntu Server 22.10 Lychee 4.6.5 Client: MacOs 12.6.2 Firefox 108.0.1

ildyria commented 1 year ago

Sorry for the late answer. Had time to dig.

I believe this is because the value of LYCHEE_UPLOADS_URL is not set in your .env

By default the value is upload/ but if you load this in a mail client, I believe this will not be working.