search

LycheeOrg / Lychee

A great looking and easy-to-use photo-management-system you can run on your server, to manage and share photos.
https://lycheeorg.github.io/
MIT License
3.3k stars 295 forks source link

Wrong password for shared album throws exception #2263

Closed svho12 closed 7 months ago

svho12 commented 7 months ago

Detailed description of the problem [REQUIRED]

If an incorrect password is entered for a shared album, an exception is thrown (Symfony exception).

Steps to reproduce the issue

Steps to reproduce the behavior:

  1. Create an album and make it public with password protection.
  2. Open the link to the album in a private browser tab and enter an incorrect password in the password prompt and click on Enter.
  3. The exception is displayed.

Screenshots

exception

Output of the diagnostics [REQUIRED]

    Diagnostics
    -----------
    Error: Wrong property for update_check_every_days, expected strictly positive integer, got 0.
    Warning: Dropbox import not working. dropbox_key is empty.
    Warning: zend.assertions is disabled although Lychee is in debug mode. For easier debugging code generation for assertions should be enabled.
    Info: Latest version of PHP is 8.3
    Warning: Online updates are disabled by configuration
    Info: Found 2 small that could be generated.
         You can use `php artisan lychee:generate_thumbs small 2` to generate them.
    Info: Found 3 small2x that could be generated.
         You can use `php artisan lychee:generate_thumbs small2x 3` to generate them.
    Info: Found 60 medium that could be generated.
         You can use `php artisan lychee:generate_thumbs medium 60` to generate them.
    Info: Found 9 medium2x that could be generated.
         You can use `php artisan lychee:generate_thumbs medium2x 9` to generate them.

    System Information
    ------------------
    Lychee Version (git):                    ?? (1e3b000) -- Could not compare.
    DB Version:                              5.1.1

    composer install:                        --no-dev
    APP_ENV:                                 production
    APP_DEBUG:                               true
    APP_URL:                                 set
    APP_DIR:                                 default
    LOG_VIEWER_ENABLED:                      true
    LIVEWIRE_ENABLED:                        true

    System:                                  Linux
    PHP Version:                             8.2.7
    PHP User agent:                          Lychee/4 (https://lycheeorg.github.io/)
    Timezone:                                Europe/Berlin
    Max uploaded file size:                  10240M
    Max post size:                           10240M
    Livewire chunk size:                     12.00 MB
    Max execution time:                      3600
    MySQL Version:                           10.3.27-MariaDB-0+deb10u1

    exec() Available:                        yes
    Imagick Available:                       1
    Imagick Enabled:                         1
    Imagick Version:                         1691
    GD Version:                              2.3.3
    Number of foreign key:                   12 found.

    Config Information
    ------------------
    version:                                 050101
    check_for_updates:                       0
    sorting_photos_col:                      taken_at
    sorting_photos_order:                    ASC
    sorting_albums_col:                      min_taken_at
    sorting_albums_order:                    ASC
    imagick:                                 1
    skip_duplicates:                         1
    small_max_width:                         0
    small_max_height:                        360
    medium_max_width:                        1920
    medium_max_height:                       1080
    lang:                                    en
    image_overlay_type:                      desc
    default_license:                         none
    compression_quality:                     90
    grants_full_photo_access:                1
    delete_imported:                         0
    mod_frame_enabled:                       1
    mod_frame_refresh:                       30
    thumb_2x:                                1
    small_2x:                                1
    medium_2x:                               1
    landing_page_enable:                     0
    site_owner:                              XXX
    landing_title:                           XXX
    landing_subtitle:                        Cats, Dogs & Humans Photography
    sm_facebook_url:                         
    sm_flickr_url:                           
    sm_twitter_url:                          
    sm_instagram_url:                        
    sm_youtube_url:                          
    landing_background:                      dist/cat.webp
    site_title:                              XXX
    footer_show_copyright:                   0
    site_copyright_begin:                    2003
    site_copyright_end:                      2024
    footer_additional_text:                  
    footer_show_social_media:                0
    search_public:                           0
    SL_enable:                               0
    SL_for_admin:                            0
    recent_age:                              1
    grants_download:                         1
    photos_wraparound:                       1
    map_display:                             1
    zip64:                                   1
    map_display_public:                      1
    map_provider:                            RRZE
    force_32bit_ids:                         0
    map_include_subalbums:                   1
    update_check_every_days:                 0
    has_exiftool:                            1
    share_button_visible:                    0
    import_via_symlink:                      0
    has_ffmpeg:                              1
    location_decoding:                       1
    location_decoding_timeout:               30
    location_show:                           1
    location_show_public:                    1
    rss_enable:                              0
    rss_recent_days:                         7
    rss_max_items:                           100
    prefer_available_xmp_metadata:           0
    editor_enabled:                          1
    lossless_optimization:                   0
    swipe_tolerance_x:                       150
    swipe_tolerance_y:                       250
    local_takestamp_video_formats:           .avi|.mov
    log_max_num_line:                        1000
    unlock_password_photos_with_url_param:   0
    nsfw_visible:                            1
    nsfw_blur:                               0
    nsfw_warning:                            0
    nsfw_warning_admin:                      0
    nsfw_banner_override:                    
    map_display_direction:                   1
    album_subtitle_type:                     oldstyle
    upload_processing_limit:                 3
    new_photos_notification:                 0
    legacy_id_redirection:                   1
    zip_deflate_level:                       6
    SA_enabled:                              0
    default_album_protection:                1
    allow_username_change:                   1
    album_decoration:                        layers
    album_decoration_orientation:            row
    auto_fix_orientation:                    1
    use_job_queues:                          0
    random_album_id:                         starred
    use_last_modified_date_when_no_exif_date: 0
    ffmpeg_path:                             /usr/bin/ffmpeg
    ffprobe_path:                            /usr/bin/ffprobe
    layout:                                  justified
    date_format_photo_thumb:                 d. F Y H:i:s \U\h\r
    date_format_photo_overlay:               d. F Y H:i:s \U\h\r
    date_format_sidebar_uploaded:            d. F Y
    date_format_sidebar_taken_at:            d. F Y H:i:s \U\h\r
    date_format_hero_min_max:                F Y
    date_format_hero_created_at:             d. F Y
    date_format_album_thumb:                 F Y
    upload_chunk_size:                       0
    nsfw_banner_blur_backdrop:               0
    search_pagination_limit:                 1000
    search_minimum_length_required:          4
    photo_layout_justified_row_height:       320
    photo_layout_masonry_column_width:       300
    photo_layout_grid_column_width:          250
    photo_layout_square_column_width:        200
    photo_layout_gap:                        12
    display_thumb_album_overlay:             always
    display_thumb_photo_overlay:             hover
    default_album_thumb_aspect_ratio:        1/1
    use_album_compact_header:                1
    login_button_position:                   left
    back_button_enabled:                     0
    back_button_text:                        Return to Home
    back_button_url:                         /

Browser and system

Safari 17.2.1 and Chrome 120.0.6099.234 on MacOS Sonoma 14.2.1

ildyria commented 7 months ago

Thank you for the heads up.

Patch is on its way see #2264.