LycheeOrg / Lychee

A great looking and easy-to-use photo-management-system you can run on your server, to manage and share photos.
https://lycheeorg.github.io/
MIT License
3.2k stars 288 forks source link

Share Button does not get disabled using share_button_visible 1/0 #2345

Closed ildyria closed 3 months ago

ildyria commented 3 months ago

Discussed in https://github.com/LycheeOrg/Lychee/discussions/2341

Originally posted by **revelnode** April 3, 2024 ### Lychee version v5.1.2 ### Which PHP version are you using? PHP 8.2 ### Detailed description of the problem Unable to disable the share button in gallery header using `share_button_visible` Whether set to 1 or 0 when viewing as an anonymous user, the share button still shows in the header of each gallery ### Steps to reproduce the issue 1. Go to Settings 2. Set `share_button_visible` to with either 1 or 0 3. Save Settings 4. View A GALLERY ### Diagnostics [REQUIRED] ``` Diagnostics ----------- Warning: /home/****************************************************/public/uploads/ has permissions 0775, but should have 2775 Warning: /home/****************************************************/public/uploads/thumb has permissions 0775, but should have 2775 Warning: /home/****************************************************/public/uploads/thumb/19 has permissions 0775, but should have 2775 Warning: /home/****************************************************/public/uploads/thumb/19/0d has permissions 0775, but should have 2775 Warning: /home/****************************************************/public/uploads/thumb/19/04 has permissions 0775, but should have 2775 Warning: 5268 more directories with wrong permissions Warning: Dropbox import not working. dropbox_key is empty. Warning: You may experience problems when uploading a photo of large size or handling many/large albums. Take a look in the FAQ for details. Warning: exec function has been disabled. You may experience some error 500, please report them to us. Info: Latest version of PHP is 8.3 System Information ------------------ Lychee Version (release): 5.1.2 DB Version: 5.1.2 composer install: --no-dev APP_ENV: production APP_DEBUG: false APP_URL: set APP_DIR: default LOG_VIEWER_ENABLED: true LIVEWIRE_ENABLED: true System: Linux PHP Version: 8.2.17 PHP User agent: Lychee/4 (https://lycheeorg.github.io/) Timezone: America/Toronto Max uploaded file size: 100M Max post size: 100M Livewire chunk size: 12.00 MB Max execution time: 60 MySQL Version: 10.6.17-MariaDB-1:10.6.17+maria~ubu2004 exec() Available: no Imagick Available: 1 Imagick Enabled: 1 Imagick Version: 1690 GD Version: 2.3.3 Number of foreign key: 12 found. Config Information ------------------ version: 050102 check_for_updates: 0 sorting_photos_col: taken_at sorting_photos_order: ASC sorting_albums_col: title sorting_albums_order: ASC imagick: 1 skip_duplicates: 0 small_max_width: 0 small_max_height: 360 medium_max_width: 1920 medium_max_height: 1080 lang: en image_overlay_type: none default_license: none compression_quality: 90 grants_full_photo_access: 1 delete_imported: 0 mod_frame_enabled: 1 mod_frame_refresh: 30 thumb_2x: 1 small_2x: 1 medium_2x: 1 landing_page_enable: 0 site_owner: ArtiVerse landing_title: John Smith landing_subtitle: Cats, Dogs & Humans Photography sm_facebook_url: https://www.facebook.com/JohnSmith sm_flickr_url: https://www.flickr.com/JohnSmith sm_twitter_url: https://www.twitter.com/JohnSmith sm_instagram_url: https://instagram.com/JohnSmith sm_youtube_url: https://www.youtube.com/JohnSmith landing_background: dist/cat.webp site_title: ArtiVerse Gallery footer_show_copyright: 1 site_copyright_begin: 2024 site_copyright_end: 2024 footer_additional_text: footer_show_social_media: 0 search_public: 0 SL_enable: 0 SL_for_admin: 0 recent_age: 1 grants_download: 0 photos_wraparound: 1 map_display: 0 zip64: 1 map_display_public: 0 map_provider: Wikimedia force_32bit_ids: 0 map_include_subalbums: 0 update_check_every_days: 3 has_exiftool: 0 share_button_visible: 0 import_via_symlink: 0 has_ffmpeg: 0 location_decoding: 0 location_decoding_timeout: 30 location_show: 1 location_show_public: 0 rss_enable: 0 rss_recent_days: 7 rss_max_items: 100 prefer_available_xmp_metadata: 0 editor_enabled: 1 lossless_optimization: 0 swipe_tolerance_x: 150 swipe_tolerance_y: 250 local_takestamp_video_formats: .avi|.mov log_max_num_line: 1000 unlock_password_photos_with_url_param: 0 nsfw_visible: 1 nsfw_blur: 0 nsfw_warning: 0 nsfw_warning_admin: 0 nsfw_banner_override: map_display_direction: 1 album_subtitle_type: oldstyle upload_processing_limit: 4 new_photos_notification: 0 legacy_id_redirection: 1 zip_deflate_level: 6 SA_enabled: 1 default_album_protection: 1 album_decoration: layers album_decoration_orientation: row allow_username_change: 1 auto_fix_orientation: 1 use_job_queues: 0 random_album_id: starred use_last_modified_date_when_no_exif_date: 0 ffmpeg_path: /usr/bin/ffmpeg ffprobe_path: /usr/bin/ffprobe layout: justified date_format_photo_thumb: M j, Y, g:i:s A e date_format_photo_overlay: M j, Y, g:i:s A e date_format_sidebar_uploaded: M j, Y, g:i:s A e date_format_sidebar_taken_at: M j, Y, g:i:s A e date_format_hero_min_max: F Y date_format_hero_created_at: M j, Y, g:i:s A T date_format_album_thumb: M Y upload_chunk_size: 0 nsfw_banner_blur_backdrop: 0 search_pagination_limit: 1000 search_minimum_length_required: 4 photo_layout_justified_row_height: 320 photo_layout_masonry_column_width: 300 photo_layout_grid_column_width: 250 photo_layout_square_column_width: 200 photo_layout_gap: 12 display_thumb_album_overlay: always display_thumb_photo_overlay: hover default_album_thumb_aspect_ratio: 16/9 use_album_compact_header: 1 login_button_position: left back_button_enabled: 0 back_button_text: Return to Home back_button_url: /``` ### Browser & System [REQUIRED] Chrome Version 123.0.6312.88 (Official Build) (64-bit) and Version 123.0.6312.106 (Official Build) (64-bit) Client - Windows 11 Server - Ubuntu 20.04.6 LTS ### Please confirm (incomplete submissions will not be addressed) - [X] I have provided easy and step-by-step instructions to reproduce the bug. - [X] I understand my bug report will be removed if I haven't met the criteria above.