LycheeOrg / Lychee

A great looking and easy-to-use photo-management-system you can run on your server, to manage and share photos.
https://lycheeorg.github.io/
MIT License
3.34k stars 299 forks source link

[Enhancement] Permit sharing of subalbums at creation #292

Open OmniTroid opened 5 years ago

OmniTroid commented 5 years ago

Say I've shared album X with user A. Now, when I create a subalbum in X, let's call it Y. However, it will not be shared with A by default, it has to be manually shared with user A. This goes for all subalbums under X..

Now, it would be a massive help if every new subalbum under X would automatically be shared with everyone who can access X (Y inherits access rights of X, if you will).

Does this seem like a reasonable request?

ildyria commented 5 years ago

While I see your point, I'm actually using it the opposite way to have more granularity on what my visitors can and cannot see. What could be done however is when creating a subalbum to add the option whether you want to replicate the sharing parameters of the parent: if public -> public. Though if the parent album is shared but not visible the the sub album would be shared but visible (inside the parent obviously).

Now, it would be a massive help if every new subalbum under X would automatically be shared with everyone who can access X (Y inherits access rights of X, if you will).

I am totally against this (the automatically).

ildyria commented 5 years ago

I edited your title to reflect a more desirable behaviour. Note that the default setting [not share|share] could be set in the config.

kamil4 commented 5 years ago

What could be done however is when creating a subalbum to add the option whether you want to replicate the sharing parameters of the parent: if public -> public.

I think ideally it could be a tri-state: yes/no/ask.

Though if the parent album is shared but not visible the the sub album would be shared but visible (inside the parent obviously).

Same with the password protection. So the only property a new subalbum should inherit is public, and probably also downloadable. And the v4-style sharing with individual users.

matthijskooijman commented 5 years ago

This is related to #12 (which discusses the reverse - whether to share children when a parent is shared).

ma-tt commented 4 years ago

+1

Let's say I create a folder called "photos of bob" and inside that album I have two sub albums called "bob at the beach" and "bob at home". Now, I share the parent album called "photos of bob" and view that link. Currently I get a blank page. Absolutely nothing.

Surely, the default behavior would be to see the content of the folder that was just shared. If people want more options, customization, or to be asked each time, that is all awesome and welcomed. Everyone loves options. But the current way it works is not at all desirable or intuitive.

verymilan commented 2 years ago

+1 for this – i was just sharing an album with contents grouped into sub-albums and then realized that i have shared an empty album.. that even remains empty when sharing a subalbum.

ildyria commented 9 months ago

There is now a global setting for that:

default_album_protection

Default protection for newly created albums. 1 = private, 2 = public, 3 = inherit from parent

blaine07 commented 5 months ago

+1

Let's say I create a folder called "photos of bob" and inside that album I have two sub albums called "bob at the beach" and "bob at home". Now, I share the parent album called "photos of bob" and view that link. Currently I get a blank page. Absolutely nothing.

Surely, the default behavior would be to see the content of the folder that was just shared. If people want more options, customization, or to be asked each time, that is all awesome and welcomed. Everyone loves options. But the current way it works is not at all desirable or intuitive.

Here to say - I wish it did this too. I shared a album and I expected this entire time all sub albums as I created them would be shared. Now I am sharing several sub albums looking like a dufus. Can this be re-visitied?

ildyria commented 5 months ago

Can this be re-visitied?

@blaine07 Would a button "propagate current permission" fix your issues ? It would be red, and would erase all the permissions from children folders and replace them with current album permission.