Lyfhael / DeleteTweets

Delete / Remove all your tweets
MIT License
639 stars 130 forks source link

Bug: Unretweet == true prevents archive deletion #65

Open rocketbrainsurgeon opened 3 weeks ago

rocketbrainsurgeon commented 3 weeks ago
"from_archive":true
"unretweet":true

These settings won't work. The array of ids to delete is [] and the script ends immediately.

"from_archive":true
"unretweet":false

This works as expected. Archive batches for deletion. Great!

There appears to be a logic error in this:

if (!isInReplyToExcludedUser && ((delete_options["unretweet"] == true && startsWithRT == true) || (delete_options["unretweet"] == false && startsWithRT == false))
&& check_filter_archive(tweet_obj)) {
;
}
else {
    return;
}
LookUpToTheRight commented 3 weeks ago

I found that to delete from the archive, all other commands for other tasks had to be set to off, so as not to interfere with the archive task. So I tend to run the archive task as a final one on its own. Took me a while to realise this.

haraldhh commented 2 days ago

Thanks, I was wondering why my account still had a lot of retweets.

haraldhh commented 2 days ago

I give up. Anyone else here that can figure out where the logic error is? It would be nice to be able to delete retweets from archive, I suppose my delete job without using the archive will take days, if not weeks.

haraldhh commented 2 days ago

I found that to delete from the archive, all other commands for other tasks had to be set to off, so as not to interfere with the archive task. So I tend to run the archive task as a final one on its own. Took me a while to realise this.

Can You please explain this a little?

LookUpToTheRight commented 2 days ago

I found that to delete from the archive, all other commands for other tasks had to be set to off, so as not to interfere with the archive task. So I tend to run the archive task as a final one on its own. Took me a while to realise this.

Can You please explain this a little?

Been a while since I last used this script, but I was saying to set the delete retweets option to true, and everything else to false. However I eventually got down to about 200+ retweets that would not delete. The author of another script on GitHub suggested this may be due to those retweets being already removed from twitter by the original tweeters, and so you are left with "ghost tweets" that nobody can find or view on twitter. He explained this on his video here. I have also tried his script and it works as well as DeleteTweets but easier to use https://youtu.be/jB1-z6LbX5w