Lykos153 / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4 stars 4 forks source link

Stuff for Silvio to check out #12

Closed eigengrau closed 6 years ago

eigengrau commented 6 years ago
eigengrau commented 6 years ago

Four decks! 💥 So, the idea, for now, was to make the deck button latch on short press, whereas long press does a momentary switch. Long press as momentary works out because when you actuate a control while keeping the button pressed, you automatically trigger a long press. So for a short adjustment to the other deck, hold the deck button and actuate the control. This returns you to your original deck.

A nice aspect about this is that this also works when you start out with the alternative deck latched (say, deck 3). Holding the deck button then allows you to tweak deck 1, but returns you to deck 3 on release. Or do a short press to cancel the latch.

eigengrau commented 6 years ago

About b671314, not sure if this would be universally considered useful. But I’ve frequently been annoyed having to long-press for a quick fader sweep, whereas (so far) I wasn’t bothered by having to switch focus after enabling some effect.

eigengrau commented 6 years ago

I realize you might have meant for there to be 32 samplers overall, 8 per deck layer (I’m not quite sure, since init sets the sampler number to 16, but the two Deck objects had 16 samplers each before my commit).

In a8874de, we have 16 samplers overall, regardless of the deck3/4 state. I figured the usual use-case would be for the sampler buttons to be global and not affected by deck toggling. But we could change that if the need arises.

eigengrau commented 6 years ago

So, in 9cc95c6, I tried to find a way to treat FX focus without having any indicator flashing constantly. Focus is indicated by the respective LED flashing briefly. Since focus is only temporarily displayed on the controller now, one needs a dedicated button for de-focusing (I went with FX-mode long press). That way it’s possible to work even without looking at the screen to see if something is focused.

eigengrau commented 6 years ago

I wonder if we should get rid of super altogether. It’s not super useful and freeing up the button would allow us to have better FX cycling (I’ve been really wanting to be able to cycle the list backwards as well as forwards; it’s really annoying if you overshoot and have to cycle the hole list again).

eigengrau commented 6 years ago

d89aa00 frees the long press assignment for the FX mode button, so in theory one could re-assign that to defocus again, though nothing currently relies on the defocused state.

eigengrau commented 6 years ago

Being able to quickly re-route is nice though. It takes a lot less effect cycling if one can simply switch effects units between decks.

eigengrau commented 6 years ago

Whoops, we need signalling from the Deck object to the effects unit now in order for this to work with 4 decks.

eigengrau commented 6 years ago

Amended.

Lykos153 commented 6 years ago

Wow! A lot of new stuff =D I'm looking forward to check it all out!

eigengrau commented 6 years ago

13d1b06 behaved a bit wonky when using it today, didn’t yet look into why exactly.

eigengrau commented 6 years ago

Never mind, should be fixed now.

Lykos153 commented 6 years ago

Great work! I especially love your improvements of the effect units!