Lykos153 / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4 stars 4 forks source link

Parameter dump upon script reload resets controls to zero #15

Open eigengrau opened 6 years ago

eigengrau commented 6 years ago

Still looking into what might be causing this. When starting mixxx, the sysex-initiated parameter dump works fine. However, when a script reload is triggered after an edit, most controls are reset to zero and will be subjected to a hard-takeover on the next controller input.

eigengrau commented 6 years ago

Oh, this might be related to the controller sending 14-bit values. I thought components.Pot, etc. had these magically covered, but it looks like we might need to bind both the MSB and LSB input explicitly within the mapping XML. Edit: doesn’t look like this is the whole solution though.

eigengrau commented 6 years ago

Got distracted. So, the issue is simply that the controller sends 0 as initial values on decks 3 and 4, but inSetParameter uses this.group, which is only changed when the components are reconnected due to a manual deck shift. On the initial dump, there is no deck shift by the user, and so the values sent for decks 3 and 4 clobber the parameters for decks 1 and 2.

This doesn’t explain why the issue doesn’t arise initially, when mixxx is started.

github-actions[bot] commented 3 years ago

This issue is marked as stale because it has been open 90 days with no activity.