search

Lykos153 / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4 stars 4 forks source link

Soft-takeover interacts with parameter dump #17

Closed eigengrau closed 3 years ago

eigengrau commented 6 years ago

Some controls (e.g., the tempo fader) are currently not initialized from the MIDI parameter dump. It looks like this is due to soft-takeover.

eigengrau commented 6 years ago

Soft-takeover of parameters should probably be toggled higher up, instead of on the level of a component. So, we could try enabling soft-takeover for all parameters in init only after the parameter dump is done. softTakeOverIgnoreNextValue would still remain in place inside the component logic.

iRet commented 3 years ago

It was related to soft take over in case of pith faders. As for the knobs, the approach when each Deck object handles two channels caused the issue. Midi dump sends values of all 4 channels and all of them used to be written to active two decks. I managed to workaround this by using custom handler that takes group from midi message instead.

upCASE commented 3 years ago

Tested this with the merged PR and it works just fine now.