search

Lykos153 / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.
http://mixxx.org
Other
4 stars 4 forks source link

Fix initial values initialization #22

Closed iRet closed 3 years ago

iRet commented 3 years ago

Issue #17

Addresses initial values issue for volume and pitch faders. EQ and gain knobs.

Lykos153 commented 3 years ago

Thanks a lot for contributing these pull requests! I'm very happy to see some activity here again! I cannot currently review any of this, because due to a lack of time I'm not actively doing anything with Mixxx and thus don't have the Roland here with me now. I'm actually inclined to give you write access to the repository. At the moment, you seem to be the best fit to hopefully finally bring this to a mergable state!

upCASE commented 3 years ago

Great to see some action here again! I had a look at both PRs and they look fine. I'll see if I can tests the changes today and merge them.

iRet commented 3 years ago

@upCASE thank you. Please don't rush I might be able to polish this up a little bit more tonight.

The default input function is taken from Component and uses this function to set value. The group is referenced as this.group and I assume determined by the active deck. While input function itself accepts the group from a midi message, inSetParameter doesn't. So the best approach I found is to override input function.

upCASE commented 3 years ago

Hi iRet,

had a very quick look at this. Initial Filter knob value is okay, but for volume, tempo and EQ I don't see a change.

iRet commented 3 years ago

@upCASE did you test it on 2.2 or 2.3? I use latest 2.3 beta.

Filter knob was working before changes for me.

upCASE commented 3 years ago

@iRet I used the latest 2.3 download on Windows 10. Removing the duplicated entry didn't change a thing.

iRet commented 3 years ago

@upCASE Surely it doesn't, just left a note for reviewer. Most likely you are a doing something wrong. I have just installed mixxx on windows to test this (not intended to use it there though)

Downloaded mapping files: Roland_DJ-202-scripts.js Roland_DJ-202.midi.xml And put them to C:\Users\<username>\AppData\Mixxx\controllers

Everything works as good as in Linux. I have recorded a video proof :) https://youtu.be/ow61NrxvYIE

upCASE commented 3 years ago

@iRet: You're right! Maybe I messed up and had the wrong file versions... Odd though, I'm pretty sure I copied them before. Anyway: works fine, thanks heaps!

upCASE commented 3 years ago

@iRet : One small thing -> should the crossfader also work? This still has the "wrong" value after start.

iRet commented 3 years ago

There is a note in 505 mapping about this, according to which it doesn't send values within the parameter dump. Author stating it is firmware issue and could be fixed in future. Personally, I didn't check the crossfader handler yet.

iRet commented 3 years ago

@upCASE similar handler did the trick for cossfader too!

upCASE commented 3 years ago

Hi @iRet , works charming! Thanks heaps for this, I never found the time to figure this out!

IMHO this can be merged now, or do you plan further updates?

iRet commented 3 years ago

I don't have any objections if you have it tested.

The only thing I can think of is FX knobs, but they need to be selected with press and hold first for work. Given thins it doesn't make any sense to read init values from them.