FX focus, rotary encoder, strip-search tweaks

Lykos153 / mixxx

Mixxx is Free DJ software that gives you everything you need to perform live mixes.

http://mixxx.org

Other

4 stars 4 forks source link

FX focus, rotary encoder, strip-search tweaks #8

Closed eigengrau closed 6 years ago

eigengrau commented 6 years ago

Not sure about 1a5eebf. Usually I expect turning a knob left/right will translate to upwards/downwards, respectively, but maybe it’s one of those things people can’t agree on.

eigengrau commented 6 years ago

As for the FX focus mapping, the timing precision argument in the commit log seems reasonable enough and long press for focus seems to work fine. That still leaves it open how the LEDs will eventually be treated. I.e., should they indicate FX status vs. focus, though.

eigengrau commented 6 years ago

Let me know if the FX focus thing doesn’t make sense to you, though. The 202 is the first controller of this sort that I’ve owned.

Lykos153 commented 6 years ago

I like what you did with the FX focus. For the LEDs I propose:

LED on/off signals FX status
LED blinks slowly: FX off and focused
LED blinks fast: FX on and focused

Usually I expect turning a knob left/right will translate to upwards/downwards, respectively

Me, too. I already wondered why you had changed it to begin with =D

Lykos153 commented 6 years ago

Just added the XML for the right half, so now it should be more or less complete. (I'll be away another week or so, thus only be able to drop a comment every now and then)