search

Lykrast / MysticalWildlife

A Minecraft mod that adds a lot of imaginary animals
MIT License
3 stars 3 forks source link

MysticalWildlife defines entries on classes that it does not own #6

Closed LuminescentMoon closed 5 years ago

LuminescentMoon commented 5 years ago

This can cause crashes that only appear on a client connected to a dedicated server (not integrated).

Log:

defineId called for: class net.minecraft.entity.EntityAgeable from class lykrast.mysticalwildlife.common.entity.EntityFurzard
defineId called for: class net.minecraft.entity.EntityAgeable from class lykrast.mysticalwildlife.common.entity.EntityYagaHog

See https://github.com/MinecraftForge/MinecraftForge/pull/5129 for more details about this issue.

This issue is that EntityDataManager is used for tracking entity data. Instead, the modern approach is to use Forge Capabilities. Here's a handy tutorial on how to implement them here.

Lykrast commented 5 years ago

Yeah that's an oversight. It's fixed on the 1.14 version so I'll make a small update to the 1.12 to fix that then.

Lykrast commented 5 years ago

Fixed for next 1.12 update (1.3.0.1) which has been sent to approval on cf.