search

Lyliya / RocketStats

BakkesMod plugin for session information (MMR, Win, Loss, Streak, eg.) in game and in OBS
https://bakkesplugins.com/plugins/view/30
MIT License
29 stars 9 forks source link

Rank in Overlay v1 missing a separator character #14

Closed user21760 closed 3 years ago

user21760 commented 3 years ago

There is no separator character between the Rank and the Division in the Overlay V1.

I think this is related to the commit that deletes a space character in the currentDivision string and adds it later. https://github.com/Lyliya/RocketStats/commit/43f4b983061b5fb2a1ce55526d12ea78a15e755b#diff-afaf366d0845a09403033ea53e6b84da022c71cfbde3cd43e412488a5ebc0ae7R476

But it doesn't add it for the V1 overlay: https://github.com/Lyliya/RocketStats/blob/916a61b5c85b4e793ad06a1b26d7c39ad50054fd/RocketStats/RocketStats.cpp#L600

user21760 commented 3 years ago

https://github.com/Lyliya/RocketStats/blob/916a61b5c85b4e793ad06a1b26d7c39ad50054fd/RocketStats/RocketStats.cpp#L600

I guess that the line: std::string tmpRank = currentRank + currentDivision; needs to change to: std::string tmpRank = currentRank + " " + currentDivision;