search

Lyn-01 / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

SUMMARY #1

Open gdedi001 opened 7 years ago

gdedi001 commented 7 years ago

Grade: Satisfactory

Great job on your project - I loved how you were able to incorporate the <div> tag making your HTML very organized! In addition to this, you utilized the <span> tag properly which allowed you to incorporate the blue font color. These two aspects of your code helped you meet the design requirements to a tee! An area for improvement here is with respect to your usage of the class attribute. In some cases you used it properly and in others not so much. Id should be substituted where there is only one instance of the class. Read the article below for more info.

A recommendation here is to review the following article. Read through it, keep the advice handy. It will aid you as your projects get more complex. Keep up the great work! 12 Principles for Clean Code id vs. class

Lyn-01 commented 7 years ago

Thank you so much for the feedback! The article on ID's and Classes was very helpful and I think I have made all the necessary changes to the html and css file. How can I view the site with the changes I have made via Github?

gdedi001 commented 7 years ago

If your site is being hosted on github, once you push your changes they should be visible.