Lynnesbian / OCRbot

An OCR (Optical Character Recognition) bot for Mastodon (and compatible) instances
https://fedi.lynnesbian.space/@OCRbot
GNU Affero General Public License v3.0
71 stars 10 forks source link

Images attached to posts that haven't federated yet aren't detected #8

Closed Lynnesbian closed 5 years ago

Lynnesbian commented 5 years ago

As the title says

Lynnesbian commented 5 years ago

If a post hasn't federated yet, it will have an in_reply_to_id of None. We need to check for this, and then somehow obtain the reply ID through other means.

Lynnesbian commented 5 years ago

the ID could be obtained by viewing the reply on its source instance, using that to obtain the reply ID, and then fetching the reply that way

it would require checking at least one separate instances, and would break if it the instance wasn't compatible with the mastodon API, but i think it's our best bet

Lynnesbian commented 5 years ago

i think, and i really hope, that this has been fixed. i haven't seen OCRbot posting the dreaded federation error so far. i won't mark it as closed quite yet, but i'm hopeful. i think https://github.com/Lynnesbian/OCRbot/commit/108c224839ca0eff938c52e184f2dd87753550ba actually worked

Lynnesbian commented 5 years ago

fixed!