Lypheo / vs-placebo

libplacebo-based debanding, scaling and color mapping plugin for VapourSynth
GNU Lesser General Public License v2.1
73 stars 13 forks source link

Fix deprecated functions, warnings & formatting #13

Closed quietvoid closed 2 years ago

quietvoid commented 2 years ago

Still need to test resample and deband outputs.

quietvoid commented 2 years ago

There's a bug with Deband when the first requested frame does not use the filter, but the 2nd one does. But it's present in current master, so I don't think it's caused by changes in the PR.

It's reproduceable with this script

import vapoursynth as vs
from vapoursynth import core

clip = core.imwri.Read('01.png')
clip = clip.resize.Spline36(format=vs.YUV420P8, matrix_s="709")

src = core.placebo.Deband(clip)
clip = core.std.Interleave([clip, src])
clip = core.placebo.Resample(clip, 2560, 1280)
clip = clip * 10

clip.set_output()

When loading an unfiltered frame first, then previewing a debanded frame, it is corrupted. So every other frame is corrupted and looks the same, for some reason.

Image: 01

edit: It appears to not happen for everyone, and only affects previews.