Closed lyquix-owner closed 6 years ago
Notes from Maustin:
Less/CSS: Nix current blk4/5/6 setup in favor of using percentages and fractions for everything. For moving Less Files to library: Off the top of my head: transitions, effects, “common,” icons, a few others. Look into SCSS PHP for compiling on the go – removes need to compile manually after every single change Make box-sizing: border-box the standard for box-sizing. For flexbox: Implement a polyfill for < 9 and also create a compatibility function that sets the max-width for IE 10 and IE 11 to prevent flex-basis from not functioning. Object Fit: cover and fix/polyfill for IE. Add new file with rules for block percentages from 1- 100% using programmatic generation to make it one time? Utilize grid to control page layout? JS: Remove unused functions in lyquix.js and/or potentially move them into separate files. Gelocate, logging, tracking, hanging punctuation, image captioning Potential layout for new Lyqbox elements: Controls on upper right, thumbnails beneath main content of the lightbox, drag and zoom with pictures as well. In general, review Lyquix.js and familiarize selves with all functions that we keep. In particular, the layout code for Lyqbox and the mobileMenu function solve issues we’ve had in the past. Separate lyquis.js into multiple files and load them similarly to how we handle less files PHP: Add a folder to lyquix flexicontent template called “fields” with files that render custom fields that are used across multiple templates instead of copying and pasting changes to override to each individual flexicontent template. Misc: Defer/Async parameter for JS and css libraries? Helps deal with performance. Use google pagespeed insights to see if it helps at all. Use minified js on dev as well as enable modpagepseed on dev Agree on common naming conventions for js and css files, and standard load order for those files.
Notes from Ruben
object-fit property, pollyfill make upgrade your browser bar for IE11 no blk 4/5/6 !!!! grid polyfill
file naming convention for js, css, php files function naming convention organization of rules and functions
fc temp php files
vue.js as js framework
scripts and styles loader merge index-custom.php and component-custom.php
LESS/CSS
Javascript
Already opened issues:
Do we want to separate the CSS rules as its own stand-alone library/framework? Same question for lyquix.js?