search

Lyr3x / Roode

A reliable smart home people counter based on VL53L1X and ESPHome
The Unlicense
150 stars 43 forks source link

Fix compatibility with ESPHome 2022.5.0 #125

Closed gorbunovav closed 2 years ago

gorbunovav commented 2 years ago

Describe the bug With the ESPHome 2022.5.0 release the set method of the Number component was removed.

The proper way to set the value is to use the make_call method: https://esphome.io/components/number/index.html?highlight=make_call

To Reproduce Update to ESPHome 2022.5.0 and try to compile the firmware.

Expected behavior Compilation completes succesfully.

Lyr3x commented 2 years ago

Thanks. Yes unfortunately they removed that function. I saw that you are working on a PR? Happy to merge if you are ready. The PR needs to be merged to upstream master. If the GitHub app is not lying you opened a PR to your fork branch

gorbunovav commented 2 years ago

@Lyr3x Hi! Yes, the PR is ready to be merged.

Lyr3x commented 2 years ago

Thank you very much for the contribution

Lyr3x commented 2 years ago

Can you open the PR to upstream please? 🙏

gorbunovav commented 2 years ago

@Lyr3x oh, sorry - I've specified the wrong target in my PR. Fixed