search

Lyr3x / Roode

A reliable smart home people counter based on VL53L1X and ESPHome
The Unlicense
149 stars 41 forks source link

Weird bug with missing esphome/components/switch.h #56

Closed jseidl closed 2 years ago

jseidl commented 2 years ago

Describe the bug Just installed the external_component on ESPHome to try it out, first build I get:

fatal error: esphome/components/switch/switch.h: No such file or directory

Which is weird since this include seems perfectly valid according to ESPHome's documentation. I'm still unsure if it's something local to me or something else but I've cleaned my whole ESPHome directory (left only the YAML files) and this was still happening. I've searched the code and didn't see Roode using switch stuff, so I just commented the include and everything worked perfectly. Maybe a leftover?

To Reproduce Steps to reproduce the behavior:

Include Roode via the following snippet:

external_components:
  - source: github://Lyr3x/Roode@master
    components: [ roode ]

Try to build your configuration. Build fails with

fatal error: esphome/components/switch/switch.h: No such file or directory

Expected behavior

Clean build.

Screenshots N/A

Additional context This might be a leftover include. Still unsure why it happens, glad removing it results in no issues so far.

Lyr3x commented 2 years ago

Can you please post your complete config? Remove any secrets upfront. Good thing is I can't reproduce it with a fresh build right now.

You are right currently roode is not using Switches anymore and it's a left over. But kind of weird that a not used import produces that error for you.

Thanks for the heads up

Lyr3x commented 2 years ago

Will be removed in #55. Thanks again!