search

Lyrics / lyrics-api

Dynamic website for the lyrics database
GNU Affero General Public License v3.0
2 stars 0 forks source link

Translations support #7

Open C0rn3j opened 5 years ago

C0rn3j commented 5 years ago

So the main database has Jen which is a song in some slavic language, and then there's an english translation for it in here.

It'd be nice if there was support for a language parameter or something so the translation can also be retrieved

defanor commented 5 years ago

Sounds good, and in the database it'd probably just be a language column. I think we should sort out more basic/essential things first (improve/polish the existing functionality), but then it would be nice to add.

defanor commented 5 years ago

Currently there's not many translations, but the linked one doesn't follow the <artist>/<album>/<song> structure. Those should be sorted out before proceeding.

C0rn3j commented 5 years ago

I see what you mean, sorted it out in a PR. I'll see about adding some more translations too. https://github.com/Lyrics/lyrics/pull/236