search

Lyrositor / CCScriptWriter

Extracts the dialogue from EarthBound and outputs it into a CCScript file.
6 stars 7 forks source link

Inventory management text is missing labels #13

Open PhoenixBound opened 5 years ago

PhoenixBound commented 5 years ago

The inventory management text beginning at l_0xc7e3fa (found in data_33 right now) is made up of multiple lines that need their own labels. They had labels for a while, but using CoilSnake 3.33, all the text is combined into one long line:

[...]
l_0xc7e3fa:
    "[19 19 00 00]{swap}@[1C 02 00] rearranged {swap}" call(l_0xc7e660) "{swap} own items and the {swap}[1C 05 00] moved.{wait}[02][19 19 00 00]{swap}@[1C 02 00] tried to give" linebreak
    "  the {swap}[1C 05 00]" linebreak
    "  to [1C 02 FF]," next
    "{load_registers}@but " call(l_0xc7e5f3) " was already carrying too much stuff.{wait}[02][19 19 00 00]{swap}@[1C 02 00] tried to add" linebreak
[...]

Besides the first line, which has a label, the rest of the lines cannot be changed without adding labels and ROM assignment statements manually.

I asked about this on the PK Hack Slack, and mrtenda suggested that 67ae87f introduced this because of the [19 19 XX YY] control codes used.

ShadowOne333 commented 5 years ago

For reference, this is how I have that label (and it's following one) in previous versions:

l_0xc7e3fa:
    "[19 19 00 00]{swap}@[1C 02 00] rearranged {swap}" call(data_37.l_0xc7e660) "{swap} own items and the {swap}[1C 05 00] moved." end

l_0xc7e42c:
    "[19 19 00 00]{swap}@[1C 02 00] tried to give" linebreak
    "  the {swap}[1C 05 00]" linebreak
    "  to [1C 02 FF]," next
    "{load_registers}@but " call(l_0xc7e5f3) " was already carrying too much stuff." end