search

Lysxia / first-class-families

First-class type families
https://hackage.haskell.org/package/first-class-families
MIT License
86 stars 12 forks source link

Modify Elem, add examples and two functions #25

Closed gspia closed 4 years ago

gspia commented 4 years ago

This commit removes the Elem bug, adds functions TakeWhile and DropWhile, and add doc-tests to some functions. In the Map-function this demostrates how function can applied partially.

If ok, this would close the elem-bug issue and do part of the doc test issue.

Lysxia commented 4 years ago

Fixes #23

gspia commented 4 years ago

For some reason the doctests didn't recognize the doc-test import of GHC.Typelits and CI failed. I added an extra import because of that. Is there a way to test locally that doc-tests work? Ah, now I know what's the problem, will modify

gspia commented 4 years ago

I was able to get doc-tests working on my local env. Interesting, the Foldr doc-test example works with 8.6.5 (locally) but not with 8.8.1 on CI. I'll check if I can try this easily with 8.8.1 locally. Do you know what's going on in this case?

gspia commented 4 years ago

Huh, this worked! I was able to set 881 on my local machine and test those doc-test things locally. But really didn't get why the original Pure2 (TL.+) suddenly didn't work on 881 while it worked on 865.

Lysxia commented 4 years ago

At the end it would be nice to squash the commits. Would you like to do it, or to let me do it?

gspia commented 4 years ago

If you please could do the squash? (I have no idea on how to do it.)

Lysxia commented 4 years ago

Thanks again! Keep em coming!