search

Lysxia / first-class-families

First-class type families
https://hackage.haskell.org/package/first-class-families
MIT License
86 stars 12 forks source link

Propose new list functions, First, Second and module Symbol #30

Closed gspia closed 4 years ago

gspia commented 4 years ago

Hi

Now I had time to make this proposal: it contains new list functions and functions First and Second into the Common-module and a totally new module Symbol that is similar to Nat-module.

I think that all (or at least should have been) are tested with doc-tests and I tried it with both 865 and 881 ghc.

I also re-ordered the functions in the list-module so that it is similar to the order in Data.List in base. Is that ok?

gspia commented 4 years ago

Hi

In addition to the conflict, I saw that this fails with 802 compiler. It's base libs don't have AppendSymbol function while for 822 it is in there.

This comes from the proposed Fcf.Data.Symbol module. How would you like to solve this one: remove the Symbol module from fcf or drop 802 from CI-pipeline?

Lysxia commented 4 years ago

I have some reservations about AppendSymbol, so let's keep it out for now, and wait for someone to come up with a feature request.

Lysxia commented 4 years ago

Don't hesitate to resolve conversations when you've addressed my individual comments :)

Lysxia commented 4 years ago

Yes that's right. EDIT: (was replying to last comment on Fcf/Data/Symbol.hs)

Lysxia commented 4 years ago

In the Symbol module, everything other than the Symbol type can be generalized and put in the Ord module.

gspia commented 4 years ago

Would the generalization be better left to another issue? I'm comparing this to Nat module and somehow feel that it would be better make changes possibly similarly to both modules.

Lysxia commented 4 years ago

That's a fair point! I'll make a few small tweaks, rebase, and merge this.