Lythom / capsule

A minecraft mod : Bring your base! Capsules can capture a region containing any blocks or machines, then deploy and undeploy at will. Inspired by Dragon Ball capsules.
MIT License
17 stars 13 forks source link

RecallEnchant causing 40% Server usage? #96

Open Chaos02 opened 1 year ago

Chaos02 commented 1 year ago

Hey, I've found some weird issue I cannot explain... I'm seeing out of a sudden a tps of 5, when normally the server is running totally fine. https://spark.lucko.me/6hLY5fv9mE

I have this spark report and could pinpoint the cause to a function of this mod: https://github.com/Lythom/capsule/blob/a1881ed43d9445ed48c31caa7710e2979359ed19/src/main/java/capsule/enchantments/RecallEnchant.java#L71C59-L71C59

Maybe the amount of item entities is a problem? None of the players have been using any capsules. Something (yet unknown) is causing these massive amount of items to be dropped apparently

Here is the world, the issue is occuring with. You can find the server system details in the report.

Running Capsule-1.18.2-6.0.95

Chaos02 commented 1 year ago

I was able to find the source of the quadrillions of items: it was a duplication bug somewhere underground (maybe caused by an RFTools builder (quarry mode) that might have mined in this direction. By eliminating the mass of items, Capsule has stopped consuming so much processing power. It still seems to be a bad habit, always checking if an item is dropped