M-Files / MFilesSamplesAndLibraries

A series of samples and libraries to help developers build applications upon the M-Files Information Management System.
http://developer.m-files.com
MIT License
66 stars 100 forks source link

ComplexConfiguration doesn't load custom dashboard by default #46

Open tbeest opened 11 months ago

tbeest commented 11 months ago

The ComplexConfiguration VAF example includes a VaultApplication.Dashboard.cs, yet loads the basic Application Name/Version/Publisher text by default. image

Including the following code within the VaultApplication class will load the dashboard, though I am left to wonder if that is the intended way:

public override string GetDashboardContent(IConfigurationRequestContext context)
{
    return GenerateDashboard();
}

image

CraigHawker commented 11 months ago

Definitely going to apply the "bug" label to this, as I can't see the reason this would be like this unless it were by accident.

That said: early next year we will be looking at the samples and libraries, so it is possible that we'll fix this as part of that wider work, rather than individually.

It is only a couple of lines as a change though, if someone wants to submit a PR that includes it.

tbeest commented 11 months ago

I could submit a PR, but what I wonder if this is the right override to include.
In this forum post you mention that GetStatusDashboardRootItems or GetApplicationOverviewDashboardContent should be overridden, rather than the GetDashboardContent I use above.

As is it is not entirely clear to me which to use when.