M-Lin-DM / Concave-Hulls

Tools for computing the concave hull of a set of points
3 stars 3 forks source link

strange case #1

Open VV-AM opened 2 years ago

VV-AM commented 2 years ago

Hi Michel,

Great job with this one - thank you very much. I am using it for computing shore area measured with radar mounted on autonomous boat. In general it works very well. However in one case I found a strange behaviour. Can you help me with finding reason for this, as I cannot figure it out myslef? In attachment you can see points (red ones) and very strange spiral line calculated with the script instead of poligon. concave points Many thanks for help. All the best!

WItold

M-Lin-DM commented 2 years ago

Hi Wltold,

Unfortunately I don't have much time to look into this with my current job. It definitely is some edge case that I guess isn't giving any error. And makes it hard to debug. I would try removing some points where where the trajectory fails to turn left, just to see if those points caused the problem. Or maybe resale the data to within [0, 1] and see if it helps. Sorry been a long time since I worked with this algorithm.

Send me the data as an .npy if you still cant fix it.

-Michael

On Sat, Apr 9, 2022, 11:18 AM VV-AM @.***> wrote:

Hi Michel,

Great job with this one - thank you very much. I am using it for computing shore area measured with radar mounted on autonomous boat. In general it works very well. However in one case I found a strange behaviour. Can you help me with finding reason for this, as I cannot figure it out myslef? In attachment you can see points (red ones) and very strange spiral line calculated with the script instead of poligon. [image: concave] https://urldefense.com/v3/__https://user-images.githubusercontent.com/71259951/162580224-90206464-fd08-4f5f-a859-9d475c90f516.PNG__;!!IKRxdwAv5BmarQ!MbekdxFsAwYw6QIzrrMrynKNk5Prh4MKTrrq3oOKXwo0vShfexe6nbL0KDET$ [image: points] https://urldefense.com/v3/__https://user-images.githubusercontent.com/71259951/162580228-c54daadd-36b2-4193-a633-d29d238a2a2c.PNG__;!!IKRxdwAv5BmarQ!MbekdxFsAwYw6QIzrrMrynKNk5Prh4MKTrrq3oOKXwo0vShfexe6nUv4AU0W$ Many thanks for help. All the best!

WItold

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/M-Lin-DM/Concave-Hulls/issues/1__;!!IKRxdwAv5BmarQ!MbekdxFsAwYw6QIzrrMrynKNk5Prh4MKTrrq3oOKXwo0vShfexe6nZ-NrkTS$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AH2KA5NMUWO3TLBGFFTDE4LVEGNUJANCNFSM5S7FOMRA__;!!IKRxdwAv5BmarQ!MbekdxFsAwYw6QIzrrMrynKNk5Prh4MKTrrq3oOKXwo0vShfexe6ndn6o34Y$ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

VV-AM commented 2 years ago

Dear Michael,

Thank you for your reply. The problem appeared after adding lower-right point, so this is somehow the reason. Without it works fine. I don’t want to bother you if you have no time – I will try to look for other algorithms for my issue.

Thank you. All the best!

Witold

@.***

dr hab. inż. Witold Kazimierski Katedra Geoinformatyki i Hydrografii profesor uczelni T: 91 48 09 319 E: @.**@.> www.wn.am.szczecin.plhttp://www.wn.am.szczecin.pl/

Akademia Morska w Szczecinie Wydział Nawigacyjny ul. Wały Chrobrego 1­-2 70-500 Szczecin

From: Michael Robert Lin @.> Sent: Wednesday, April 13, 2022 3:21 AM To: M-Lin-DM/Concave-Hulls @.> Cc: Witold Kazimierski @.>; Author @.> Subject: Re: [M-Lin-DM/Concave-Hulls] strange case (Issue #1)

Hi Wltold,

Unfortunately I don't have much time to look into this with my current job. It definitely is some edge case that I guess isn't giving any error. And makes it hard to debug. I would try removing some points where where the trajectory fails to turn left, just to see if those points caused the problem. Or maybe resale the data to within [0, 1] and see if it helps. Sorry been a long time since I worked with this algorithm.

Send me the data as an .npy if you still cant fix it.

-Michael

On Sat, Apr 9, 2022, 11:18 AM VV-AM @.<mailto:@.>> wrote:

Hi Michel,

Great job with this one - thank you very much. I am using it for computing shore area measured with radar mounted on autonomous boat. In general it works very well. However in one case I found a strange behaviour. Can you help me with finding reason for this, as I cannot figure it out myslef? In attachment you can see points (red ones) and very strange spiral line calculated with the script instead of poligon. [image: concave] https://urldefense.com/v3/__https://user-images.githubusercontent.com/71259951/162580224-90206464-fd08-4f5f-a859-9d475c90f516.PNG__;!!IKRxdwAv5BmarQ!MbekdxFsAwYw6QIzrrMrynKNk5Prh4MKTrrq3oOKXwo0vShfexe6nbL0KDET$<https://urldefense.com/v3/__https:/user-images.githubusercontent.com/71259951/162580224-90206464-fd08-4f5f-a859-9d475c90f516.PNG__;!!IKRxdwAv5BmarQ!MbekdxFsAwYw6QIzrrMrynKNk5Prh4MKTrrq3oOKXwo0vShfexe6nbL0KDET$> [image: points] https://urldefense.com/v3/__https://user-images.githubusercontent.com/71259951/162580228-c54daadd-36b2-4193-a633-d29d238a2a2c.PNG__;!!IKRxdwAv5BmarQ!MbekdxFsAwYw6QIzrrMrynKNk5Prh4MKTrrq3oOKXwo0vShfexe6nUv4AU0W$<https://urldefense.com/v3/__https:/user-images.githubusercontent.com/71259951/162580228-c54daadd-36b2-4193-a633-d29d238a2a2c.PNG__;!!IKRxdwAv5BmarQ!MbekdxFsAwYw6QIzrrMrynKNk5Prh4MKTrrq3oOKXwo0vShfexe6nUv4AU0W$> Many thanks for help. All the best!

WItold

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/M-Lin-DM/Concave-Hulls/issues/1__;!!IKRxdwAv5BmarQ!MbekdxFsAwYw6QIzrrMrynKNk5Prh4MKTrrq3oOKXwo0vShfexe6nZ-NrkTS$<https://urldefense.com/v3/__https:/github.com/M-Lin-DM/Concave-Hulls/issues/1__;!!IKRxdwAv5BmarQ!MbekdxFsAwYw6QIzrrMrynKNk5Prh4MKTrrq3oOKXwo0vShfexe6nZ-NrkTS$>, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AH2KA5NMUWO3TLBGFFTDE4LVEGNUJANCNFSM5S7FOMRA__;!!IKRxdwAv5BmarQ!MbekdxFsAwYw6QIzrrMrynKNk5Prh4MKTrrq3oOKXwo0vShfexe6ndn6o34Y$<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AH2KA5NMUWO3TLBGFFTDE4LVEGNUJANCNFSM5S7FOMRA__;!!IKRxdwAv5BmarQ!MbekdxFsAwYw6QIzrrMrynKNk5Prh4MKTrrq3oOKXwo0vShfexe6ndn6o34Y$> . You are receiving this because you are subscribed to this thread.Message ID: @.<mailto:@.>>

— Reply to this email directly, view it on GitHubhttps://github.com/M-Lin-DM/Concave-Hulls/issues/1#issuecomment-1097453487, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ7VOL5WEILJBMAVTYCVWFDVEYOQFANCNFSM5S7FOMRA. You are receiving this because you authored the thread.Message ID: @.**@.>>