search

M-Reimer / toggleanigif

GNU General Public License v3.0
16 stars 1 forks source link

Doesn't toggle and hover gif don't animate #19

Closed donkoch closed 1 month ago

donkoch commented 2 months ago

Once you freeze a gif, you can't unfreeze it (toggle doesn't). It also seems to freezes all the gifs on the page.

Hover to animate gifs, like on Tumblr, won't animate if this extension is merely enable. https://www.tumblr.com/dandelionandkrindle/758127784587640832/the-harbinger-of-the-kingdom-that-was

Firefox 127.0.2 on linux (fedora 40).

M-Reimer commented 2 months ago

Will try later.

But how did you attempt to "freeze"? If you want to freeze individual images, you have to enable the context menu item in the Add-on settings.

donkoch commented 2 months ago

It is enabled. It shows up in the menu. It seemed to work until I added the shortcut (maybe coincidental). That seemed to work, too. Then all gif animation failed, even after removing the shortcut.

donkoch commented 2 months ago

Just tried an uninstall/reinstall and it seems to be happy, again. I suspect something is getting cached that breaks it. Will update after some more testing.

M-Reimer commented 2 months ago

I'm somewhat limited to what Firefox allows me to do. The "global toggle" DOES require a page reload so you see the effect. That's how Firefox is programmed internally and that's why you can toggle an auto page reload in the settings. The "freeze" feature was added as an optional addition as it somewhat fits with the global toggle feature. It can be used completely independent of the global toggle and also works if you don't use the toolbar button. It is disabled by default as interacting with the website requires full page content access which I don't want to request by default if a user doesn't actually need this feature. Technically it creates a "screenshot" of the image area and replaces the animated image with the screenshot. That's also why a page reload is needed to "unfreeze" as the former image information is lost in this process.

M-Reimer commented 1 month ago

Any news?

donkoch commented 1 month ago

Haven't seen a non-hover gif in a while. Had to do an uninstall-reinstall to fix it from before.

M-Reimer commented 1 month ago

So I guess I can close the issue for now?

donkoch commented 1 month ago

Found some GIFs. Now it won't freeze them. I give up. Uninstalling as it is totally useles.

M-Reimer commented 1 month ago

Actually I likely just found what your actual problem is. This "tumblr" page does not actually use regular image sources but image sets. I want to try something tomorrow.

donkoch commented 1 month ago

OK. I will await a resolution and try again. Thanks.

M-Reimer commented 1 month ago

New version is on its way. For me every single image on tumblr freezes with this change.

Edit: And it is on AMO already. Please tell me if this fixes your problem.