search

M-Reimer / undoclosetab

Undo Close Tab Add-on for Firefox
GNU General Public License v3.0
92 stars 16 forks source link

Undo Close Tab button icon doesn't go shade pale when Firefox window is unfocused #136

Closed Aleksandra0056 closed 3 months ago

Aleksandra0056 commented 3 months ago

The Undo Close Tab button icon doesn't go shade pale when the Firefox window is unfocused, but other icons yes.

My solution is to make the Undo Close Tab follow the behaviour of the icon going shade pale when the Firefox window is unfocused.

Undo Close Tab icon on Focused Firefox window: Focused window

Undo Close Tab icon on Unfocused Firefox window: Unfocused window

My theme which is on screenshots is: https://addons.mozilla.org/en-US/firefox/addon/rosa-pink/

Aleksandra0056 commented 3 months ago

This same applies to the Toggle Image Animations extension, but I write it here to avoid bug trackers cluttering

Toggle Image Animations icon of Focused Firefox window: Toggle Image Animations focused window

Toggle Image Animations icon of Unfocused Firefox window: Toggle Image Animations unfocused window

M-Reimer commented 3 months ago

Thanks for reporting. Probably all I can do is handle this as duplicate of https://github.com/M-Reimer/undoclosetab/issues/90 or similar.

What I can do with the icon is VERY limited, unfortunately. In my opinion it is not at all uncommon to try to mimic the Firefox icon style but Mozilla intentionally makes this very difficult.

Probably I could detect the window loosing focus and then replace the icon. But that would just add on top of already way too much workaround code and as far as I see this behavior only exists on Windows. For me Windows is not the primary platform to develop for. I don't even have a Windows system to test with.

M-Reimer commented 3 months ago

I tried on my work laptop, which is the only location where I still can access Windows. It is a Windows 11 installation. I tried focusing/unfocusing windows and on Windows 11 nothing "goes shade pale". So it even isn't consistent across the Windows platform. There is absolutely no way for Add-ons to detect this case. Would have to be fixed in the Firefox backend. So if this has priority for you, please report here: https://bugzilla.mozilla.org/home