search

M-Reimer / undoclosetab

Undo Close Tab Add-on for Firefox
GNU General Public License v3.0
92 stars 16 forks source link

Use Photon colors for icons #29

Closed rugk closed 6 years ago

rugk commented 6 years ago

It would be nice if you could use the Photon colors for the icons, so they match the rest of Firefox' design.

M-Reimer commented 6 years ago

Thanks for the information. Didn't know about this one and the color, so far, was based on a screenshot taken from the Firefox window.

rugk commented 6 years ago

As far as I see, you did not use the transparency of the color. Actually that is totally possible (and recommend) in the SVG though!

M-Reimer commented 6 years ago

I did. It is not possible in the "color" directly. And it is not possible in the individual elements either as I have two overlapping items. So I had to group the two and add the opacity value to the group: https://github.com/M-Reimer/undoclosetab/blob/master/icons/undoclosetab.svg?short_path=5292d4f#L55

rugk commented 6 years ago

Ah, okay… BTW you could also use https://jakearchibald.github.io/svgomg/ for minifying the SVG.

M-Reimer commented 6 years ago

I don't think a few extra bytes are a problem. Dropping them may result in problems when editing again. If this would really result in any advantages, I could create a Makefile rule to create a minified version based on the version, I use for editing, but I don't think it's worth the trouble.

rugk commented 6 years ago

Of course you need to keep the old version. :smile:

A different 8though not so hardly optimized way) is to save the SVG as "Optimized SVG" in Inkscape.

M-Reimer commented 6 years ago

IMHO it is nice and handy that Firefox opens the file, I use for editing, directly.

If it would really result in any noticeable improvement, I would definitively add some optimization. Most probably just in form of some more "sed" rules in the Makefile to drop or simplify some stuff.

M-Reimer commented 6 years ago

I think this is similar to all the other source files. In theory I could minify my .js files, too to save a few nanoseconds on Firefox startup.