search

M-Reimer / undoclosetab

Undo Close Tab Add-on for Firefox
GNU General Public License v3.0
92 stars 16 forks source link

Reopen last closed tab on right-click menu #34

Closed feierfrosch closed 6 years ago

feierfrosch commented 6 years ago

Hello,

is it possible to add a function to the right-click menu that doesn't give me the list of the last closed tabs, but simply re-opens the last closed one? I used to rightclick and press G (_G_eschlossenen Tab wiederherstellen) in quick succession on the old FF, but that funcionality apparently was added by TMP which is not available for the new one.

M-Reimer commented 6 years ago

Thanks for adding this as issue.

I think this could be a great new feature.

This would have to be added as another optional menu item, but "interlocked" with the existing option (each Addon can only add one submenu item).

BUT the first implementation would most probably not have the access key ("G" in your example) as this is only possible in Firefox 63 and I have to be compatible down to at least Firefox 60.

M-Reimer commented 6 years ago

Fixed in 4.3.0. "Access keys" are not possible in Firefox 62, which is the current "stable" Firefox release. If you really need this, please create a follow-up issue.

feierfrosch commented 6 years ago

I have no idea what "access keys" are. When I right-click right now and press "G", it opens the dropdown list of closed tabs (using the current version of your extension in German). So why is it not possible to set this behaviour to open the last closed tab? I don't understand why Mozilla had to change that and make it (at some parts: way!) worse than it was before -.-'

M-Reimer commented 6 years ago

You are right. So this issue is resolved.

"Access keys" would be underlined in the context menu. I didn't know that I can just use the first character of the menu item label. So adding this "accesskey" feature would just be a cosmetic change and not needed to get the actual functionality.

feierfrosch commented 6 years ago

Maybe "access keys" (I guess that's the underlined ones) provide some kind of preference in case that there are more entries with the same first character? So, stating that the "issue is resolved" - will you add this feature? :)

M-Reimer commented 6 years ago

Not in the near future. Especially as this doesn't work in the current stable Firefox at all.

In English and German language, the "access key" is the first one anyway, so there is not much need for this (currently not usable) feature. But I would add this for the other supported languages, if needed, as soon as Firefox 63 is out.