search

M-Reimer / undoclosetab

Undo Close Tab Add-on for Firefox
GNU General Public License v3.0
92 stars 16 forks source link

Doesn't work on Firefox 71.0 #69

Closed VictoriousRaptor closed 4 years ago

VictoriousRaptor commented 4 years ago

Nothing happens when I click the icon. Firfox Ver 71.0 undoclosetab 5.0.0

M-Reimer commented 4 years ago

It does work on Firefox 71. I just tested a few seconds ago.

So we should try to find out what's wrong on your side.

Please start with opening the "Browser Console" by pressing Ctrl+Shift+J

On the top right corner you find a settings menu in the "Browser Console" window. Open it and check "Show Content Messages".

Now click the "Undo Close Tab" toolbar icon and keep a look at possible error messages in the "Browser Console" log window. If you see one that could match to your clicks, please post a screenshot of this.

VictoriousRaptor commented 4 years ago

Just tried uninstall & reinstall the extension and still doesn't work.

2019-12-29 232815

The error message above occurs everytime I refresh a page.

2019-12-29 232835

This is what happens when I click the icon. Seems like my browser is broken?

M-Reimer commented 4 years ago

Duplicate of https://github.com/M-Reimer/undoclosetab/issues/38 And basically a bug in Firefox. I really would also like to have this fixed, but WebExtensions bugs seem to have pretty low priority for Mozilla. I have filed several bugs and monitor some others. They rarely get updates. Some of them are unchanged for over a year.

But let's try to fix your installation.

Is it OK if we reset your session? You would have to bookmark all relevant tabs first so you don't loose anything.

Then go to your Firefox preferences. (Menu --> Preferences or enter "about:preferences" into your address bar). Directly on the start page, remove the check in the checkbox "Restore previous session". After doing so, restart Firefox once. This should reset your session and also "unbreak" the sessions API.

Please report back if this fixes this problem for you.

Of course if this fixed your installation, you may recheck "Restore previsions session" now to have the new session restored (for as long as it takes to get broken again).

VictoriousRaptor commented 4 years ago

I did what you said and it works pretty well now. Thanks!

M-Reimer commented 4 years ago

Thank you for verifying.

This also means that we now have a (validated) workaround. Time to create some step-by-step instruction with screenshots for this.

M-Reimer commented 4 years ago

I've created some step-by-step instructions: https://github.com/M-Reimer/undoclosetab/wiki/How-to-fix-broken-browser-session