search

M-Reimer / undoclosetab

Undo Close Tab Add-on for Firefox
GNU General Public License v3.0
89 stars 17 forks source link

On Firefox addon may not pick the correct light or dark icon for the browser theme #90

Open dpalacio opened 3 years ago

dpalacio commented 3 years ago

With some themes this addon will fail to select the proper light/dark icon variant for its toolbar icon. Once it picks an icon, it is unlikely to select the proper icon again if Firefox changes from a light to a dark theme, or viceversa. A browser restart is enough to set the correct icon for the Dark theme. In the case of Simple Materia Theme - Red, though, it initially loads the correct icon but seconds later ends up with a dark icon on dark background.

Firefox version: Firefox ESR 78.8 Themes tested: Light, Dark, Simple Materia Theme - Red

https://addons.mozilla.org/en-US/firefox/addon/nicothin-space/ https://addons.mozilla.org/en-US/firefox/addon/materia-dark/ https://addons.mozilla.org/en-US/firefox/addon/starry-3/ https://addons.mozilla.org/en-US/firefox/addon/material-mlq/

vokoscreenNG-2021-03-14_12-36-58.zip

M-Reimer commented 3 years ago

I will have a look at this but maybe more "step by step" instructions would be needed.

There is a good chance that this can't be fixed at all (invalid) as Mozilla really makes it hard to get dynamic icons working. I already have a list of workarounds implemented...

And actually: You can't dynamically switch Themes and expect icons to be correct. This is broken in Firefox. Set your theme, restart browser. If it works that way, then there is no bug in my Add-on.

dpalacio commented 3 years ago

I will have a look at this but maybe more "step by step" instructions would be needed.

Sure, I'll do! What kind of instructions would you like?

There is a good chance that this can't be fixed at all (invalid) as Mozilla really makes it hard to get dynamic icons working. I already have a list of workarounds implemented...

It's interesting that the multi-account containers and temporary containers seem to have, somehow, support for theme changes. It isn't perfect either, though.

And actually: You can't dynamically switch Themes and expect icons to be correct. This is broken in Firefox. Set your theme, restart browser. If it works that way, then there is no bug in my Add-on.

I understand you. I wouldn't mind and may have not reported if it did work as expected on restart but, as you can see in the video, it shows fine for about a second before it reverts to the odd icon. So the addon does pick the correct icon at first, on restart.

M-Reimer commented 3 years ago

I did a few tries. I managed to get the icon to be stuck once but creating a new window (Ctrl + N) already solved this.

It is not me who is able to manage this. There are several bugs in the theme handling which are not fixed since some time.

See issue #92 for example which also depends on Mozilla fixing their stuff. There is a good chance that this issue is also fixed once Mozilla decides to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1542044 so I'll close this Issue here.

M-Reimer commented 3 years ago

OK. Maybe better to keep this for reference so the links above don't get lost for future tests. But for now I'll not do any further tests. The Add-ons API in Firefox is broken in several ways. I did try to workaround many issues, but some stuff is just ugly and in the end it's Mozilla's task to finally add more resources to backend development. Firefox could be so much better if Mozilla did more backend development and did not prefer to completely redesign the GUI every few months... :disappointed: