M-Reimer / wine-lol

PKGBUILDs to package GloriousEggroll's LoL-patched wine version
163 stars 20 forks source link

add wine-lol script to path #106

Closed saltedcoffii closed 8 months ago

saltedcoffii commented 2 years ago

The PATH to the wine-lol executable, on arch linux via the AUR at least, is cumbersome to access, and shares the same prefix with the system wine, which can cause problems if they are too far different. Have you considered adding a script such as

#!/usr/bin/env sh
winelolprefix=${WINEPREFIX:-"${HOME}/.wine-lol"}
env WINEPREFIX="${winelolprefix}" /opt/wine-lol/bin/wine "${@}"

to the PATH, such as at /usr/bin/wine-lol

DanRiffo commented 1 year ago

I do not agree with this. When you use an alternative wine you have to be responsible about your own wineprefixes. No need for the maintainer to add clutter/bloat with a mostly useless script. Just my two cents.

M-Reimer commented 8 months ago

Most users use helpers or scripts anyway. And it is not my job to "standardize" where the LoL wine prefix should be. It could be in a number of different locations depending on which guide or helper you use.

saltedcoffii commented 8 months ago

I understand your point, and it does make sense from a technical perspective. However, many users may not have an intricate understanding of how to use wine and want something that "just works." Having a script as such may increase ease of use for users that run Linux and just want to play League without having to configure or understand wine prefixes. If my script doesn't match the needs of the project or the needs of the majority of nontechnical users, maybe another solution would be better, such as adding working instructions to the README explaining how to set up a helper to use wine-lol. I use bottles, for example. If such scripts or instructions exceed the scope of the project, consider linking to an article explaining such use.

M-Reimer commented 8 months ago

The "solution" for the "non-technical" users is https://aur.archlinux.org/packages/leagueoflegends-git And the "really non-technical user" probably doesn't need all of this and will use Lutris anyway.

M-Reimer commented 8 months ago

Added some note to the README.md file which now points to leagueoflegends-git, too.

I only want to do basic maintenance and no longer want to spend too much time into wine-lol. Currently, I'm quite happy that all it does is build or repackage the wine version provided by GloriousEggroll. If I add some script, then people will come with all kinds of feature requests that I do not want to deal with.

I no longer play LoL AT ALL since many years and I'm not planning to get back into it. All I still try to do is support the Linux Gaming community a bit. I do not use wine-lol by myself!