Closed kyechou closed 1 year ago
Please do not remove the "epoch". I can't merge directly this way.
Ah okay I thought it's only needed when pkgver was lower. I'll update my commit in a sec
I've confirmed both wine-lol
and wine-lol-bin
in this PR work with the client and game in practice tool.
Added back the epochs.
So I guess the "futex.patch" is now part of the new release?
Yes, it's included in one of the lol patches now.
Can you please also leave the "$pkgname-$pkgver.tar.gz::" in for the source archive? I'm building with a global source directory and without this I get regular source file conflicts.
Yeah sure. sorry about that
OK. The file name is the SHA hash in this case. So no conflict potential. Just a ugly file name which is difficult to know where it belongs to. If you prefer the SHA there, it would be OK for me. But actually I think it is better to properly name source files. Especially with global source file directories.
Make sense. just updated the tarball source renaming.
Thanks for the fast help. Did someone else build test this? I'm sure the "-bin" will work but I will not have the time today to build test the "non bin" PKGBUILD. If someone verifies that this works, then I can update AUR.
I've built and played the practice tool with both builds. It seems @thesmartwon had success too. But it'd be nice if others can confirm as well.
I think the current version on AUR is broken anyway. So I'll sync this over and hope possible problems get reported as a new Issue.
Done. Thanks for your PR. About the epoch: This was needed as GloriousEggroll at some point rolled back to a previous release. And once you have an "epoch" in your PKGBUILD, it should stay there as this marks a "start of a new timeline".
I've just finished the game with this wine-lol
recipe, it builds and works correctly, no freezes in game nor in post game lobby.
Release: https://github.com/GloriousEggroll/wine-ge-custom/releases/tag/7.0-GE-8-LoL
The new release fixes a few issues with running the game on Linux. Tested and fix #116.
References: