Add Dockerfile to the repo which lets you build on **any** distro

philipwilk commented 3 years ago

What is this?

This Dockerfile takes the existing PKGBUILDs and uses them to build wine-lol-glibc and then wine-lol using a freshly picked archlinux:latest container image, and then putting them into the directory you've mounted when you run the container.

Why do we need this?

This lets any distro that supports containers to build the packages; the build machines do not need to be arch based. This simplifies building the packages as only two unchanging commands are required, which have no impact on your machine whatsoever. This is preferable over installing the dependencies on your local machine or bootstrapping a virtual machine, as it will always be the same environment; no 'It worked on my machine' or time wasted setting up the build environment, ever!

Are there any changes in the packages themselves if they're built with this?

No.

Added complexity?

One singe Dockerfile is added to the repo root, which uses preexisting PKGBUILDs to build everything for you (only one file is added to the repo which actually controls the container image).
Dockerfile syntax is very, very simple and can be understood by someone who has never even seen it before, and should be very easily maintainable with the comments left.
The multi-stage building used in the image could actually save you time if any change is made to wine, but not to glibc - only wine will be rebuilt; only modified parts of the container image will be built again, everything unchanged will use cache.

M-Reimer commented 3 years ago

Will this still work if moved to a "contrib" directory? I wont maintain or use this.

philipwilk commented 3 years ago

Yes, however, the ADD commands (which copy from host filesystem to container filesystem) on lines 13 and 43 use standard linux directories to get to the folders for wine and glibc relative to that Dockerfile. This means that the sources for them (wine-lol/ and wine-lol-glibc/) will need to have ../ added before them so they'll resolve. Also, feel free to add a comment at the top listing me as the maintainer for it or something (# for a comment).

M-Reimer commented 3 years ago

Applied now. But currently this is broken anyway. More info: https://www.reddit.com/r/leagueoflinux/comments/pb4wqy/did_the_upgrade_to_cef91_as_part_of_1117_break/

M-Reimer / wine-lol