M-Welsch / backup-server

Backup Server (BaSe)

Apache License 2.0

3 stars 1 forks source link

avoid shell=True #41

Open M-Welsch opened 7 months ago

M-Welsch commented 7 months ago

Description

subprocess.run( ... , shell=True)

should be avoided, because it is a security issue

What happens if we don't do it (aka Why is it important)?

we have a possible security leak

Definition of Ready

[ ] Milestone MVP is done

Key Tasks

[ ] clarify where shell=True is necessary and ok

Acceptance Criteria

[ ] we know where shell=True is necessary
[ ] we have shell=False in every other subprocess call