search

M-Zuber / MyHome

Home finance management
MIT License
24 stars 21 forks source link

Fix for issue #99 - Shallow copy methods (and tests) for categories #117

Closed AlexBHarley closed 8 years ago

AlexBHarley commented 8 years ago

Adding shallow copy methods for the ExpenseCategory and IncomeCategory classes - as well as accompanying unit tests

Review on Reviewable

M-Zuber commented 8 years ago

Welcome on board. Thank you for contributing.

The code looks great, one little nitpick - can you add a similar Copy method for the PaymentMethod type?

AlexBHarley commented 8 years ago

There's quite a lot of duplicate code here. Would it be better to have a generic Copy method, that takes a type? I think I could make it work. Let me know what you think.

M-Zuber commented 8 years ago

That definitely sounds interesting. Would love to see a POC. In the meantime I will merge this, so if you don't mind open a new PR with the updated code