search

M-Zuber / npm-watch

run npm scripts when files change
MIT License
324 stars 38 forks source link

inherit flag + Jest problem #27

Open geoffreydhuyvetters opened 7 years ago

geoffreydhuyvetters commented 7 years ago

When I use Jest with npm-watch and use inherit: true, npm-watch doesn't show me the failed tests.

If I don't set inherit it seems to work but I get no coloring.

Is there a solution to make both work?

thanks in advance :)

M-Zuber commented 7 years ago

I apologize for the late reply. This is related to #23. I would really appreciate it if you could tell me which repo you are having issues on so that I can test it locally. If you can not share it publicly my email is mez613@gmail.com

geoffreydhuyvetters commented 7 years ago

https://github.com/duivvv/validate-note

Change inherit to true and cause a failed test (rename one of the errors is the easiest way I guess)

M-Zuber commented 7 years ago

Thank you very much! Hopefully I have found the problem. Will publish and notify you here once I've confirmed

stevenvachon commented 7 years ago

nodemon uses child_process, which does not simulate a TTY. This would be a source of some logging issues. We could switch to node-pty.

M-Zuber commented 7 years ago

Is that something you would be interested in trying to put together a pull request for?

stevenvachon commented 7 years ago

Perhaps, but not sure when.