codecov[bot]
commented
7 months ago Codecov Report
Attention: 73 lines in your changes are missing coverage. Please review.
Comparison is base (
d57c212) 71.11% compared to head (d5e4c37) 69.02%.
| Files | Patch % | Lines |
|---|---|---|
| src/server/connection.rs | 56.00% | 33 Missing :warning: |
| src/auth/server.rs | 40.00% | 12 Missing :warning: |
| src/utils/tasks.rs | 0.00% | 11 Missing :warning: |
| src/server.rs | 63.63% | 8 Missing :warning: |
| src/server/tunnel.rs | 78.94% | 8 Missing :warning: |
| src/client.rs | 0.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #32 +/- ## ========================================== - Coverage 71.11% 69.02% -2.10% ========================================== Files 19 19 Lines 1011 975 -36 ========================================== - Hits 719 673 -46 - Misses 292 302 +10 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR refactors how error handling works for the server side of Quincy.
Before, a cleanup task ran periodically for
QuincyServerandQuincyTunnel, which collected stale tunnels/connections and cleaned them up.Now, all tasks are immediately awaited, which allowed for significant refactoring of error handling.