search

M0nica / how-many-days-until

A React countdown app of days between today and next year.
https://m0nica.github.io/how-many-days-until/
10 stars 32 forks source link

Fix Flow type issues in resgisterServiceWorker.js #40

Closed M0nica closed 4 years ago

M0nica commented 5 years ago 
   42:11  error  Unexpected console statement                      no-console
   55:26  error  Missing "swUrl" parameter type annotation         flowtype/require-parameter-type
   58:11  error  Missing "registration" parameter type annotation  flowtype/require-parameter-type
   68:15  error  Unexpected console statement                      no-console
   73:15  error  Unexpected console statement                      no-console
   79:12  error  Missing "error" parameter type annotation         flowtype/require-parameter-type
   80:7   error  Unexpected console statement                      no-console
   84:34  error  Missing "swUrl" parameter type annotation         flowtype/require-parameter-type
   87:11  error  Missing "response" parameter type annotation      flowtype/require-parameter-type
   94:44  error  Missing "registration" parameter type annotation  flowtype/require-parameter-type
  105:7   error  Unexpected console statement                      no-console
  113:40  error  Missing "registration" parameter type annotation  flowtype/require-parameter-type

run npm lint to view these errors locally

These are related to Flow which is a static type checker https://flow.org/

marcosnils commented 5 years ago

I can help.

github-actions[bot] commented 4 years ago

Stale issue message