search

M0nica / httriri

HTTRiRi - HTTP Status Codes as Portrayed by Rihanna GIFs ✨💄
https://www.httriri.com/
GNU General Public License v3.0
55 stars 22 forks source link

##Add Rihanna GIF for Status Code 599 #50 #53

Closed hulyak closed 3 years ago

hulyak commented 3 years ago

599: Network Connect Timeout Error

Relates to #

https://github.com/M0nica/httriri/issues/ #50

Pages/Interfaces that will change

Steps to test

I ran the project on localhost:3000

Additional notes

M0nica commented 3 years ago

@hulyak thank you for your contribution. The GIF you submitted is already in use for “406: Not Acceptable ↗”. Can you change the image?

In the README it indicates:

The GIF should include Rihanna and not already be included on https://www.httriri.com/. In rare cases, a GIF that already exists in the HTTRIRI collection can be used for another status code but within the same set of proposed changes a new GIF should be chosen for the other status code to ensure there are no duplicate images and the overall size of the collection is growing

M0nica commented 3 years ago

There’s currently another PR that was opened to add 599. https://github.com/M0nica/httriri/pull/57. If the requested changes are not made within 48 hours I will review PR 57.

hulyak commented 3 years ago

Hi, I have made a new pull request #75 with a different image.

M0nica commented 3 years ago

Closing as the new GIF for 599 was added in https://github.com/M0nica/httriri/pull/75