search

M0nica / httriri

HTTRiRi - HTTP Status Codes as Portrayed by Rihanna GIFs ✨💄
https://www.httriri.com/
GNU General Public License v3.0
55 stars 22 forks source link

Add Rihanna gif for 504 Status code #58

Closed mehtavishwa30 closed 3 years ago

mehtavishwa30 commented 3 years ago

Description of Changes

Relates to #43 https://github.com/M0nica/httriri/issues/43

M0nica commented 3 years ago

Thank you for this contribution, the GIF you added for 504 currently is the same as the one for 403: Forbidden. Can you please update your PR as per the README "The GIF should include Rihanna and not already be included on https://www.httriri.com/. In rare cases, a GIF that already exists in the HTTRIRI collection can be used for another status code but within the same set of proposed changes a new GIF should be chosen for the other status code to ensure there are no duplicate images and the overall size of the collection is growing".

mehtavishwa30 commented 3 years ago

Thanks for the note! I'll make the changes asap.

M0nica commented 3 years ago

Closing this as the GIF is a duplicate. If you'd like to add a new image for 504 status code, if it hasn't been added yet that then you may./