search

M0r13n / pyais

AIS message decoding and encoding in Python (AIVDM/AIVDO)
MIT License
176 stars 61 forks source link

NoneFilter broken #128

Closed webstey closed 7 months ago

webstey commented 7 months ago

NoneFilter was not filtering anything out for me. I changed 'False' to 'None' in this line and it works now. It looks like you were providing 'False' as the default to getattr, but then checking for 'None'. I may be missing some intended behaviour that my change breaks, but this worked for me.

https://github.com/M0r13n/pyais/blob/6ec596bb131966c6172e96401d786055fa80c82f/pyais/filter.py#L151

M0r13n commented 7 months ago

@webstey You are right. That's a rather dumb bug on my part. Thank you for bringing this up. :)

Fixed in version 2.6.1