search

M17-Project / M17_spec

M17 standard specification
GNU General Public License v2.0
149 stars 33 forks source link

Difference between mvoice IP Encapsulation implementation and spec. #57

Closed wgaylord closed 3 years ago

wgaylord commented 3 years ago

While developing my own server for M17 I found that a few packets don't follow the spec.

For example in the spec a ACKN should have the encoded Address (callsign and module) after the magic, but if you do this the mvoice client does not connect, instead if you send it just the magic ACKN it connects properly.

I think this might be more of a wording issue, as under the CONN packet format it says the reflector replies with a ACKN, which I think means just "ACKN" and not actually a ACKN packet as one might assume while reading the spec.

I think it might be a good idea to write out all packets that are sent back and forward for control, as the PING packet is not documented, thankfully its just a PONG packet with PING used instead of PONG.

wgaylord commented 3 years ago

I will be making a PR with changes to document some of this stuff based off how current implementation are using the spec. (For example mvoice and dudestar assume ACKN packets to be just the word "ACKN")

wgaylord commented 3 years ago

Closed the my pull request.