Closed GoogleCodeExporter closed 9 years ago
The attached patch fixes this issue and does not cause any unit tests to fail
that aren't already failing.
Original comment by gunter...@gmail.com
on 18 Oct 2011 at 7:34
Attachments:
Scratch that first patch; it feels too much like a hack. I'm attaching a new
patch that I consider a much better solution.
Original comment by gunter...@gmail.com
on 18 Oct 2011 at 9:13
Attachments:
This issue was closed by revision r94.
Original comment by pejob...@gmail.com
on 19 Oct 2011 at 9:47
@gunter
Could you elaborate on the suggested change in
"ExternalNameSpace.putExternalMap(String, Object)"?
I didn't applied this part of the fix.
Test case is green without this change (for test case see r93,
http://code.google.com/p/beanshell2/source/browse/trunk/tests/junitTests/src/bsh
/Issue_55_Test.java)
Original comment by pejob...@gmail.com
on 19 Oct 2011 at 9:55
The idea behind that change to putExternalMap(..) was that the absence of the
key indicates void, while the presence of the key mapped to a null value
indicates null. If an attempt were made to map a name to VOID, that bit of code
would prevent the name from being added to the map.
Looking at it now, though, I see that VOID assignments should not be possible
so that particular change should not be necessary. The fix you've applied works
for me. Thank you!
Original comment by gunter...@gmail.com
on 19 Oct 2011 at 12:51
Original comment by pejob...@gmail.com
on 20 Oct 2011 at 7:12
Issue 60 has been merged into this issue.
Original comment by pejob...@gmail.com
on 16 Nov 2011 at 9:26
Original issue reported on code.google.com by
gunter...@gmail.com
on 18 Oct 2011 at 3:51Attachments: