search

M4444 / TMatrix

Terminal based replica of the digital rain from The Matrix.
GNU General Public License v2.0
380 stars 14 forks source link

Zsh completion & cmake installation #14

Closed eliasrg closed 5 years ago

eliasrg commented 5 years ago

As if making a package wasn't enough procrastination to avoid studying for my exams... I decided to take this project as an opportunity to learn about zsh completions. I also added the script to CMakeLists, and while I was at it moved the executable to /usr/bin and included the man page. Unfortunately this doesn't split cleanly into two pull requests although it deals with two different issues.

M4444 commented 5 years ago

Hi again :) Thanks for taking such an interest in this project.

eliasrg commented 5 years ago

I have made some changes. See the comments on the outdated changes for details.

M4444 commented 5 years ago

The CMake install commit has been merged.

eliasrg commented 5 years ago

The CMake install commit has been merged.

Great! You may want to alert the packagers downstream, since they probably had to install the man page explicitly from their build scripts before. The Arch Linux package is already updated.

M4444 commented 5 years ago

Oh nice, thanks!

M4444 commented 5 years ago

I'll close this since we're focusing on #16. Thanks for the contribution.