Fallback to home page - Githubissues

M4SS-Code / cargo-goggles

Verify that registry crates in your Cargo.lock are reproducible from the git repository

https://crates.io/crates/cargo-goggles

Apache License 2.0

36 stars 2 forks source link

Fallback to home page #6

Open VorpalBlade opened 6 months ago

VorpalBlade commented 6 months ago

Package tiny-keccak is missing `repository` attribute in Cargo.toml
Package crunchy is missing `repository` attribute in Cargo.toml

tiny-keccack does have a homepage attribtute that point at the github repo. Perhaps a fallback would be viable?
https://lib.rs/crates/crunchy does find the repo and link it. I have absolutely no idea how as the info is completely missing.

Neither of them have tagged releases, so that doesn't help very much though.

paolobarbolini commented 6 months ago

https://lib.rs/crates/crunchy does find the repo and link it. I have absolutely no idea how as the info is completely missing.

I've asked on Mastodon and I was told they check if https://github.com/{owner_name}/{crate_name} exists

VorpalBlade commented 6 months ago

That is a wonderful hack. But, I would be reluctant to include such things myself if I were you.

paolobarbolini commented 6 months ago

But, I would be reluctant to include such things myself if I were you.

Yeah I agree. I'd much prefer fixing the problem by sending PRs fixing Cargo.toml metadata and then have a local override to be in the meantime able to scan the crate anyway.

link2xt commented 6 months ago

https://lib.rs/crates/crunchy does find the repo and link it. I have absolutely no idea how as the info is completely missing.

I've asked on Mastodon and I was told they check if https://github.com/{owner_name}/{crate_name} exists

I also found their repo by looking for the GitHub user which published the crate. Every upload on crates.io is tied to a GitHub account, so it works.