search

M4rtinK / modrana

ModRana is a flexible GPS navigation system for mobile devices. This is the main upstream modRana source code repository - waiting for your pull requests & patches! :)
www.modrana.org
GNU General Public License v3.0
66 stars 21 forks source link

add support for OSM Scout Server routing V2, fixes #207 #212

Closed rinigus closed 7 years ago

rinigus commented 7 years ago

This PR adds support for V2 routing protocol allowing to use it with Valhalla and libosmscout routing responses.

M4rtinK commented 7 years ago

Wow, thanks a lot! :)

I got back from Japan about 10 days ago (Japan was really nice - can only recommend!) but haven't really got to normal yet modRana development wise due to various things (unpacking, fighting jetlag, talking to friends about Japan, work, etc.) and I'll be on one more week of vacation next week - this time just in a cottage at the Vranov dam lake with friends. :)

After that I'll hopefully be able to get back to general modRana development & properly review & test (and likely outright merge) both of your pull requests. :)

BTW, thanks yet again for adding support for latin names in Japan/non latin countries - it worked just fine (once I actually managed to download the updated date over unstable hotel WiFi :) )!

I posted about it on Twitter - linking here in case you have not seen it yet: https://twitter.com/M4rtinK/status/892228772597874689 https://twitter.com/M4rtinK/status/892228772597874689 There are also some pictures from our travels on my Twitter account in Japan in case you want to check them out. :)

rinigus commented 7 years ago

Its always good to take the break - and thank you for twitter messages (I am not using twitter though).

PS: Japan is impressive, indeed. I was there a while ago...

rinigus commented 7 years ago

Hi, any chance to look into this? :)

M4rtinK commented 7 years ago

Hi, any chance to look into this? :)

Things have finally settled a bit so I'll take a look either today or during the weekend. :)

M4rtinK commented 7 years ago

This is what I was getting when testing the PR on Czech Republic data on my Jolla C:

ERROR mod.routing.providers: OSM Scout Server routing: failed with exception Traceback (most recent call last): File "./core/routing_providers.py", line 327, in search print(replyData) UnicodeEncodeError: 'ascii' codec can't encode character '\u017e' in position 860: ordinal not in range(128)

Everything worked fine once I removed the print() calls.

rinigus commented 7 years ago

Yes, these print calls should be just dropped. Sorry for forgetting them in the code (used for debug)

rinigus commented 7 years ago

Print calls removed

M4rtinK commented 7 years ago

Thanks! Merging now! :)